Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DryIoc] Update default container rules. #1463

Merged
merged 1 commit into from Jun 10, 2018

Conversation

Dudulle
Copy link
Contributor

@Dudulle Dudulle commented Jun 10, 2018

Description of Change

Update default container rules in Prism.DryIoc.Wpf and Prism.DryIoc.Forms.

Type registration from DryIocContainerExtension has become inconsistent between WPF and Xamarin since commit 9b82533.
This commit makes both platforms behave the same way again.

Moving the mentioned changes to the default container rules makes type registration from the container and container extension behave consistently and allows to override the behavior of the container extension.

Bugs Fixed

Fixes a bug equivalent to #1304 on WPF platform.

API Changes

None

Behavioral Changes

By default, the container will resolve types using the constructor with the most resolvable arguments.
The container extension will use default rules for registration (no change for WPF).

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

         Keep behavior consistent between WPF and Xamarin platforms.
@dnfclas
Copy link

dnfclas commented Jun 10, 2018

CLA assistant check
All CLA requirements met.

Copy link
Member

@dansiegel dansiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, if we are updating the default Rules, go ahead and clean up the ContainerExtenstion for Forms.

@Dudulle
Copy link
Contributor Author

Dudulle commented Jun 10, 2018

@dansiegel do you mean this file? (WPF did not have those parameters, which is why I mentioned the behavior was currently inconsistent)
Or did I miss something else?

@dansiegel
Copy link
Member

sorry was looking at this on my phone earlier... thought that was the WPF one... LGTM

@dansiegel dansiegel merged commit c1a29a4 into PrismLibrary:master Jun 10, 2018
@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants