Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Alignment #1476

Merged
merged 2 commits into from
Jun 14, 2018
Merged

Module Alignment #1476

merged 2 commits into from
Jun 14, 2018

Conversation

dansiegel
Copy link
Member

Description of Change

Migrating Module Exceptions, ModuleInfo, IModuleInitializer, and IModuleManager from WPF to Prism.Core. Removing duplicates in Prism.Forms.

Bugs Fixed

Aligning Modularity API per #1290

API Changes

  • IModuleManager.ModuleDownloadProgressChanged (available in net45 aka WPF ONLY)
  • IModuleManager.LoadModuleCompleted - Forms will now invoke this event when a new module has been loaded. Note there is not currently a default handler provided by PrismApplication.

WPF

Added:

  • Type based constructors from Prism.Forms version
    • ModuleInfo(Type)
    • ModuleInfo(Type, string)
    • ModuleInfo(Type, string, InitializationMode)

Changed:

  • (BREAKING) ModuleInfo is now in Prism.Core. This may affect apps that have defined their ModuleCatalog in XAML as this may require a change to your namespace.

Forms

While any existing code creating a new ModuleInfo by Type will continue to work, ModuleInfo is now in Prism.Core and has adopted the WPF Version which changes the ModuleType parameter from Type to string, this may introduce a Breaking Change for anyone directly referencing the ModuleType. Note that the Type string is simply Type.AssemblyQualifiedName.

Behavioral Changes

see above

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dansiegel dansiegel added this to the Prism 7.1 for Xamarin.Forms milestone Jun 14, 2018
@dansiegel dansiegel mentioned this pull request Jun 14, 2018
3 tasks
@dansiegel dansiegel merged commit 7356b9c into master Jun 14, 2018
@dansiegel dansiegel deleted the module-minor branch June 14, 2018 22:29
@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant