Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module updates #1509

Merged
merged 9 commits into from
Jul 19, 2018
Merged

Module updates #1509

merged 9 commits into from
Jul 19, 2018

Conversation

dansiegel
Copy link
Member

Description of Change

Making Module Migration less breaking for WPF. Implements Module Dependencies for Xamarin Forms. Updates project dependencies.

Bugs Fixed

  • Fixed issue with broken tests in Debug configuration

API Changes

List all API changes here (or just put None), example:

Added:

  • IModuleInfo to Prism.Core (ModuleInfo moved back to Wpf & Forms)

Changed:

  • IModuleInitializer
    • void Initialize(ModuleInfo) -> void Initialize(IModuleInfo)
  • LoadModuleCompletedEventArgs
    • ModuleInfo property is now IModuleInfo
  • ModuleDownloadProgressChangedEventArgs
    • ModuleInfo property is now IModuleInfo
  • ModuleDependencyAttribute -> Moved to Prism.Core

Behavioral Changes

  • ModuleManager (Prism.Forms)
    • Now loads any Module Dependencies
  • ModuleInfo (Prism.Forms)
    • Will now initialize the DependsOn with any dependencies from ModuleDependencyAttribute found decorating the ModuleType
    • NOTE: This affects Prism.Forms ONLY, as this would create a behavior change we aren't sure we want to introduce on WPF.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

/// <summary>
/// Defines the metadata that describes a module.
/// </summary>
public partial class ModuleInfo : IModuleCatalogItem, IModuleInfo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't IModuleInfo implement IModuleCatalogItem? So no need to declare them both?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to pull it off that one

@dansiegel dansiegel merged commit bd49627 into master Jul 19, 2018
@dansiegel dansiegel deleted the module-updates branch July 19, 2018 18:10
@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants