Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluent API for IContainerRegistry fixes #1677 #1705

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Fluent API for IContainerRegistry fixes #1677 #1705

merged 1 commit into from
Feb 20, 2019

Conversation

dansiegel
Copy link
Member

Description of Change

Updates IContainerRegistry to allow registration chaining
fixes #1677

Bugs Fixed

n/a

API Changes

Changed:

  • void IContainerRegistry.Register => IContainerRegistry IContainerRegistry.Register
  • void IContainerRegistry.RegisterSingleton => IContainerRegistry IContainerRegistry.RegisterSingleton
  • void IContainerRegistry.RegisterInstance => IContainerRegistry IContainerRegistry.RegisterInstance

Behavioral Changes

n/a

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dansiegel dansiegel merged commit a9e22df into master Feb 20, 2019
@dansiegel dansiegel deleted the fluent-containerregistry branch February 20, 2019 03:16
@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fluent API for IContainerRegistryExtensions
1 participant
@dansiegel