Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Implements IInitialize #1779

Merged
merged 4 commits into from
Apr 25, 2019
Merged

[BREAKING] Implements IInitialize #1779

merged 4 commits into from
Apr 25, 2019

Conversation

dansiegel
Copy link
Member

Description of Change

This implements IInitialize, IInitializeAsync & IAutoInitialize

Fixes #1746
Fixes #1748

Bugs Fixed

  • Corrects issue with OnNavigatingTo being used improperly

API Changes

List all API changes here (or just put None), example:

Added:

  • void IInitialize.Initialize(INavigationParameters)
  • Task IInitialize.InitializeAsync(INavigationParameters)
  • IAutoInitialize
    Removed:
  • INavigatingAware
  • void INavigationAware.OnNavigatingTo(INavigationParameters)

Behavioral Changes

[BREAKING] INavigatingAware has been made Obsolete and removed from INavigationAware. This means all ViewModels implementing INavigationAware will no longer have OnNavigatingAware called, nor will there be a build warning or error.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dansiegel dansiegel merged commit ae667e7 into master Apr 25, 2019
@dansiegel dansiegel deleted the IInitialize branch April 25, 2019 01:39
@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Implement IInitialize (BREAKING) [Feature] Bind Navigation Parameters directly to ViewModel
2 participants