Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not override owner in DialogService #1815

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Do not override owner in DialogService #1815

merged 1 commit into from
Jun 5, 2019

Conversation

hronlukas
Copy link

Do not override owner in DialogService

Bugs Fixed

API Changes

None

Behavioral Changes

Check DialogWindow's Owner whether is null during configuration.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dnfclas
Copy link

dnfclas commented May 29, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@hronlukas hronlukas mentioned this pull request May 29, 2019
Closed
@brianlagunas brianlagunas merged commit 428df87 into PrismLibrary:master Jun 5, 2019
@brianlagunas
Copy link
Member

Thanks or the PR

@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hronlukas @dnfclas @brianlagunas