Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ContainerProviderExtension #2069

Merged
merged 8 commits into from Jul 2, 2020
Merged

Add ContainerProviderExtension #2069

merged 8 commits into from Jul 2, 2020

Conversation

gayaK
Copy link
Contributor

@gayaK gayaK commented Apr 20, 2020 •
edited

Description of Change

Fixes #2041

API Changes

Added:

  • XAML markup extension: {prism:ContainerProvider Type={x:Type MyType}, Name=TargetName}

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dnfclas
Copy link

dnfclas commented Apr 20, 2020 •
edited

CLA assistant check
All CLA requirements met.

@brianlagunas
Copy link
Member

Could you please provide unit tests for this feature?

@gayaK
Copy link
Contributor Author

gayaK commented Apr 25, 2020

@brianlagunas
Yes, please wait several days.

@gayaK gayaK marked this pull request as ready for review April 26, 2020 07:56
@gayaK
Copy link
Contributor Author

gayaK commented Apr 26, 2020

Sorry. I'm fixing CI errors.

@gayaK gayaK changed the title Add ContainerProviderExtension [WIP] Add ContainerProviderExtension Apr 26, 2020
@gayaK gayaK changed the title [WIP] Add ContainerProviderExtension Add ContainerProviderExtension May 2, 2020
@stale stale bot added the wontfix label Jul 2, 2020
@dansiegel dansiegel removed the wontfix label Jul 2, 2020
@PrismLibrary PrismLibrary deleted a comment from stale bot Jul 2, 2020
@brianlagunas brianlagunas merged commit 695606b into PrismLibrary:master Jul 2, 2020
@brianlagunas
Copy link
Member

Thank you so much for the PR. Sorry it took so long for me to get to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dansiegel dansiegel dansiegel approved these changes

@brianlagunas brianlagunas Awaiting requested review from brianlagunas brianlagunas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add ContainerProvider for XAML in WPF
4 participants
@gayaK @dnfclas @brianlagunas @dansiegel