Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Tests and fixes issues with AutoRegistrationForNavigation #2089

Merged
merged 3 commits into from
Apr 24, 2020

Conversation

dansiegel
Copy link
Member

Description of Change

adding tests for AutoRegisterForNavigation - fixes #2088

Bugs Fixed

  • Fixes issue with NavigationPage/TabbedPage not being registered.

API Changes

none

Behavioral Changes

Fixes issue with NavigationPage and TabbedPage not being automatically added and custom naming not working

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dansiegel dansiegel merged commit 9f75d1a into master Apr 24, 2020
@dansiegel dansiegel deleted the autoregister branch April 24, 2020 03:48
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

1 similar comment
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Housekeeping] Add tests around AutoRegisterForNavigation
1 participant