Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows library resources #2094

Merged
merged 2 commits into from Apr 24, 2020
Merged

Fix Windows library resources #2094

merged 2 commits into from Apr 24, 2020

Conversation

jeromelaban
Copy link
Contributor

Description of Change

  • Fixes the missing resources in the uap10.0 target for Windows
  • Removes the unused CommonServiceLocator dependency for uap10.0

Bugs Fixed

PR Checklist

- [ ] Has tests (if omitted, state reason in description)

  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@jeromelaban jeromelaban mentioned this pull request Apr 24, 2020
Closed
@dansiegel dansiegel merged commit 130ed2a into PrismLibrary:master Apr 24, 2020
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

1 similar comment
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dansiegel dansiegel dansiegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Prism.Unity.Uno 8.0.0.1693-ci doesn't work on UWP
2 participants
@jeromelaban @dansiegel