Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uno-UWP] Disable library layout generation #2101

Merged
merged 1 commit into from
Apr 24, 2020
Merged

[Uno-UWP] Disable library layout generation #2101

merged 1 commit into from
Apr 24, 2020

Conversation

jeromelaban
Copy link
Contributor

@jeromelaban jeromelaban commented Apr 24, 2020 •
edited
Loading

Description of Change

Library layout generation is disabled for Prism.DryIoc.Uno and Prism.Unity.Uno projects as they do not have any XAML files, and that if set to true, there is an nuget issue where Uno.Prism PRI resources get incorrectly propagated to their dependents.

Without this change, a UWP build fails with the following error:

error APPX1101: Payload contains two or more files with the same destination path 'Prism.Uno\Prism.Uno.xr.xml'. Source files: 
error APPX1101: C:\Users\XX\.nuget\packages\prism.dryioc.uno\8.0.0.1693-ci\lib\uap10.0.16299\Prism.Uno\Prism.Uno.xr.xml
error APPX1101: C:\Users\XX\.nuget\packages\prism.uno\8.0.0.1693-ci\lib\uap10.0.16299\Prism.Uno\Prism.Uno.xr.xml

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@jeromelaban
fix(uno-uwp): Disable library layout generation
be92542 
Library layout generation is disabled for Prism.DryIoc.Uno and Prism.Unity.Uno projects as they do not have any XAML files, and that if set to true, there is an nuget issue where Uno.Prism PRI resource get incorrectly propagated to their dependents.
@jeromelaban jeromelaban changed the title fix(uno-uwp): Disable library layout generation [Uno-UWP] Disable library layout generation Apr 24, 2020
@jeromelaban jeromelaban marked this pull request as ready for review April 24, 2020 22:13
@dansiegel dansiegel merged commit 8597347 into PrismLibrary:master Apr 24, 2020
@jeromelaban jeromelaban deleted the dev/jela/uwp-fix branch April 25, 2020 00:22
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dansiegel dansiegel dansiegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeromelaban @dansiegel