Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Remove Legacy Bootstrapper #2178

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Conversation

brianlagunas
Copy link
Member

@brianlagunas brianlagunas commented Aug 23, 2020

Description of Change

I am officially removing the old, legacy bootstrapper class from Prism. There are two upgrade paths for developers using the old legacy UnityBootstrapper.

  • Switch to using the PrismApplication class
  • Upgrade your current UnityBootstrapper to the new PrismBootstrapper

Bugs Fixed

API Changes

List all API changes here (or just put None), example:

Removed:

  • UnityBootstrapper
  • DryIocBootstrapper

Behavioral Changes

This is a major breaking change. Upgrading to the PrismApplication or PrismBootstrapper will not change any behavior in your application.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

also updated all tests to use new bootstrapper
@brianlagunas brianlagunas changed the title [Breaking] Remove Lr=egacy Bootstrapper [Breaking] Remove Legacy Bootstrapper Aug 23, 2020
Copy link
Member

@dansiegel dansiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally it looks good to me. I just would fix the manager.Run() call since this would introduce a bug as the ContainerExtensions expects to be able to resolve a type or throw an exception.

src/Wpf/Prism.Wpf/PrismInitializationExtensions.cs Outdated Show resolved Hide resolved
@dansiegel dansiegel merged commit 5a06d41 into master Aug 24, 2020
@dansiegel dansiegel deleted the remove-lagcy-bootstrappers branch August 24, 2020 20:46
@dansiegel dansiegel added this to the Prism 8.0 milestone Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants