Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WPF to .NET 5 #2250

Merged
merged 13 commits into from Jan 26, 2021
Merged

Update WPF to .NET 5 #2250

merged 13 commits into from Jan 26, 2021

Conversation

brianlagunas
Copy link
Member

Description of Change

Updated Prism for WPF to .NET 5

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

still having issues with unit tests
this was needed in order to fix the StaFact attribute not working on various tests. This is because the StaFact no longer supports older versions of .NET
src/Prism.Core/Prism.Core.csproj Outdated Show resolved Hide resolved
@kekonn
Copy link

kekonn commented Nov 14, 2020

What else do you need to make this happen? I'm waiting on this to become real to start a project.

@brianlagunas
Copy link
Member Author

@kekonn a passing build. Apparently, Azure Devops hasn't been updated to work with .NET 5 yet.

@kekonn
Copy link

kekonn commented Nov 15, 2020

That's.... Rough

@kekonn
Copy link

kekonn commented Nov 19, 2020

@brianlagunas I'm not sure about Azure, but Github Action's default .net core runner supports .NET 5. I've already used it to build .NET 5 projects. Is it a big conversion?

EDIT: Apparently a new build VM image with VS 16.8 is being pushed to Pipeline next week.

@brianlagunas
Copy link
Member Author

Yay! Can't wait for that.

@brianlagunas
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@brianlagunas
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dansiegel dansiegel merged commit 5d37175 into master Jan 26, 2021
@dansiegel dansiegel deleted the net5 branch January 26, 2021 21:42
@dansiegel dansiegel added this to the Prism 8.1 milestone May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants