IActiveAware activates inactive views #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansiegel
force-pushed
the
active-aware-fix
branch
from
2e4692d
to
f44a585
Compare
brianlagunas
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This updates the behaviors to help ensure that we do not accidently mark a View/ViewModel as active when it technically is not. For instance in the case where a NavigationPage is child of a TabbedPage. The NavigationPage may not be the active tab of the TabbedPage while the CurrentPage of the NavigationPage will still be marked as active.
This ensures that all children of the NavigationPage are in fact not active in this scenario.
Bugs Fixed
API Changes
n/a
Behavioral Changes
Adds additional checks before setting IActiveAware.IsActive