Adding Exception Handler #2887
Merged
Adding Exception Handler #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansiegel
force-pushed
the
dev/ds/command-catch
branch
from
8668204
to
7ca126d
Compare
brianlagunas
reviewed
Jul 7, 2023
brianlagunas
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This adds a MulticastExceptionHandler. This allows some flexibility in being able to provide more dynamic types which includes the ability to specify strongly typed Exception handlers for specific Exception types.
Bugs Fixed
API Changes
Adds public API's to the DelegateCommand for
Catch<TException>Behavioral Changes
When a Catch is specified this will attempt to catch any exception thrown during the execution of the command. If no delegate is registered for it, it will rethrow the exception.
NOTE for
DelegateCommand<T>the protected implementation has been updated to no longer call theExecute(T parameter)and instead now will simply call the delegate directly. This is because we need to also allow developers to catch an InvalidCastException in the event that the UI Framework causes this error.