Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog Consolidation #2888

Merged
merged 25 commits into from Aug 17, 2023
Merged

Dialog Consolidation #2888

merged 25 commits into from Aug 17, 2023

Conversation

dansiegel
Copy link
Member

Description of Change

This aim's to unify the Dialog abstractions to work effectively the same across all platforms. With this we gain the ability to reshare code across WPF, MAUI, Xamarin.Forms, & Uno Platform as the core interfaces reside within the Prism.Core. Note that the Show API and WindowName API in WPF & Uno Platform are now extensions for backwards compatibility . These functions are now driven through KnownDialogParamters.

@DamianSuess
Copy link
Contributor

Interesting PR on the consolidation. On the Prism.Avalonia's side, I'm currently making some changes to the DialogService for the next 2023-Q2 release. Overall, this looks very beneficial.

@dansiegel Do you foresee any integration issues?

For starters, I was making the ShowDialog's Action<IDialogResult> callback optional (AvaloniaCommunity/Prism.Avalonia#79).

Also, overloaded ShowDialog to optionally supply a parent window for modal dialogs (AvaloniaCommunity/Prism.Avalonia#76). Because Avalonia operates differently than WPF, I have to explicitly set the parent whether it's the main window or another dialog window.

@dansiegel
Copy link
Member Author

@DamianSuess overall I think it should make it easier for you. The Core is meant to have the extensions to provide backwards compatibility. Currently the one thing which is platform specific and may still change is that the extensions for Show are in WPF since this is the only platform which implements such functionality.

@DamianSuess
Copy link
Contributor

DamianSuess commented Jun 23, 2023

Thanks, Dan, I appreciate the feedback on the topic.
I can rest a bit better this weekend now. Hope you get to as well ;)

@dansiegel dansiegel merged commit 9f75a26 into master Aug 17, 2023
5 checks passed
@brianlagunas brianlagunas deleted the dev/ds/dialogs branch August 17, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants