Add nullable annotations to commands #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I understand that what has failed is not my fault since it is in a checkout step. |
dansiegel
approved these changes
Sep 17, 2023
|
@dansiegel is the PR ready to merge? You have not answered to the doubt that I have raised initially, I do not know if you agree with my approach or you have not read it. Thank you! |
|
@bdovaz just waiting on a review from @brianlagunas |
|
I'm hesitant to add this now since we are in the middle of a major effort, but Dan doesn't mind dealing with any issues that come of this 🤣 . |
brianlagunas
approved these changes
Sep 19, 2023
|
@brianlagunas my idea is to help you step by step to implement it by parts in different PR, project by project (Example: Prism.Core) and block by block (Example: Commands). |
|
Thanks for the PR @bdovaz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have also taken the opportunity to apply the features of new versions of C#.
I have concerns on how to act on the AsyncDelegateCommand when casting. I have chosen to use ! (null-forgiving) but I want your opinion.