Prism.Avalonia Library #3127
Prism.Avalonia Library #3127
Conversation
|
Thanks for the PR. I'll try to review this as soon as I can. |
There was a problem hiding this comment.
noticing this is largely just reusing what currently exists in the Prism.Avalonia project. This should start removing duplicated code, similar to what we've done with Prism for Uno.WinUI using linked code from the Prism.Wpf project where possible. The goal should be to have a minimally different API surface and eliminate duplicate code as much as possible.
| "src\\Containers\\Prism.DryIoc.Shared\\Prism.DryIoc.Shared.shproj", | ||
| "src\\Avalonia\\Prism.Avalonia\\Prism.Avalonia.csproj", | ||
| "src\\Avalonia\\Prism.DryIoc.Avalonia\\Prism.DryIoc.Avalonia.csproj", | ||
| "tests\\Avalonia\\Prism.Avalonia.Tests\\Prism.Avalonia.Tests.csproj", | ||
| "tests\\Avalonia\\Prism.DryIoc.Avalonia.Tests\\Prism.DryIoc.Avalonia.Tests.csproj" |
There was a problem hiding this comment.
this would need to be updated
There was a problem hiding this comment.
Thank you Dan for the quick response on this one. I was curious about the best strategy to move forward with regarding that. In the first round, I was planning on getting a solid build running and then minimizing if that's okay. The current import is based on tag, v9.0.401-pre.
An example of super-minor differences is WPF's DependencyObject vs. Avalonia's AvaloniaObject.
I'll take a look into the Uno.WinUI implementation, thank you for the tip. Currently, I'm working on the importation of the tests
|
btw be sure to update the CI Builds. It should be pretty much copy/paste and change the file names... if you need some help on it let me know.
|
Description of Change
Adds fixture for Prism.Avalonia using Avalonia v11.0.x. Importing from the latest v9.0.x-pre release.
API Changes
None
Behavioral Changes
Allows users to utilize the cross-platform framework Avalonia for desktop applications.
PR Checklist