Pickaxe recipe upside down?

[njt1982]

minecraft-data/data/pc/1.13.2/recipes.json

Lines 6745 to 6769 in a3bdea5

	"473": [
	{
	"inShape": [
	[
	null,
	497,
	null
	],
	[
	null,
	497,
	null
	],
	[
	482,
	482,
	482
	]
	],
	"result": {
	"count": 1,
	"id": 473
	}
	}
	],

According to https://minecraft.gamepedia.com/Pickaxe the iron should be along the top, not along the bottom.

Why is the recipe vertically inverted?

[rom1504]

good question. Let's check the burger extractor

[njt1982]

It's not just the pickaxe, I think it's all of them...

https://github.com/PrismarineJS/burger-extractor/blob/878b8b1345f9e798bc8b0aa74dd611d5519dc447/src/extractors/recipes.js#L29-L55

I'm not quite sure how that section of code results an a 2D array shape... It looks like it loops over the "line" and converts item names into numeric IDs?

[TheDudeFromCI]

In the array, the recipes are made assuming that inventory slot 0 is the bottom left corner of the grid, and slot 8 is the top right.

[njt1982]

Ahhh I thought 0 was top left!

Thanks @TheDudeFromCI - I wonder if this should be documented here:
https://github.com/PrismarineJS/minecraft-data/blob/95f19e5/doc/recipes.md

[TheDudeFromCI]

Probably, yeah. I'll make a PR.

[TheDudeFromCI]

So, apparently I never followed up on this issue. The recipes are indeed upside down and shouldn't be. The indices were loaded incorrectly which switching between versions.

Relevant discussions:
PrismarineJS/mineflayer#1112
PrismarineJS/prismarine-recipe#4

[njt1982]

@TheDudeFromCI so is the bug in the burger extractor that I linked to in #231 (comment) ?

[TheDudeFromCI]

Most likely, yeah. I guess when the chance in 1.13 occured, the way data was stored is changed. The extractor wasn't updated properly, I'm guessing.

[njt1982]

So in that code, it loops over the shape backwards (--j)... is it just a simple matter of making it go forwards now?! 🤷🏻‍♂️

[TheDudeFromCI]

Also checking the Minecraft version, but yes.

I guess it was never really a hard issue to solve. Even ignoring the extractors, someone could just write a simple 10 line JS script to import/flip/export them. I just don't think anyone's gotten around to it.

[njt1982]

@TheDudeFromCI You mean like this? 😉

https://github.com/njt1982/minecraft-item-browser/blob/5b73ce8de666fa2aaca1b943e1c980e2da7c26d6/src/components/Recipe.vue#L60-L67

EDIT: wondering why that snippet reference isn't expanding out into a code snippet preview

[TheDudeFromCI]

Yep, basically.

[Ghosin9]

bump! sorta solved, the crafting recipes are upside down, reversing them worked!

[rom1504]

Can you edit the file in GitHub with what you did ?

…

On Mon, Dec 7, 2020, 00:34 Ly Phung ***@***.***> wrote: bump! sorta solved, the crafting recipes are upside down, reversing them worked! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#231 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR437R72VPRPXKHEJ4YF3DSTQII3ANCNFSM4G7PBSHQ> .