Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several 1.20.2 recipes have invalid shape data (PC) #804

Closed
qpn6ph9q opened this issue Dec 15, 2023 · 2 comments · Fixed by #805
Closed

Several 1.20.2 recipes have invalid shape data (PC) #804

qpn6ph9q opened this issue Dec 15, 2023 · 2 comments · Fixed by #805

Comments

@qpn6ph9q
Copy link

Several recipes in https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.20.2/recipes.json have invalid shape data.

For example: The shape data for iron_door (688) has the orientation flipped in the 1.20.2 data:

  "688": [
	{
	  "inShape": [
		[
		  770,
		  770,
		  770
		],
		[
		  770,
		  770,
		  770
		]
	  ],
	  "result": {
		"id": 688,
		"count": 3
	  }
	}
  ]

The shape data is correct in the 1.20.0/1.20.1 data:

  "688": [
	{
	  "inShape": [
		[
		  770,
		  770
		],
		[
		  770,
		  770
		],
		[
		  770,
		  770
		]
	  ],
	  "result": {
		"count": 3,
		"id": 688
	  }
	}
  ]
@wgaylord
Copy link
Contributor

Interesting, looks like https://github.com/PrismarineJS/minecraft-data-generator-server does not output the recipes in the same shape that what ever tool was used for 1.20.1 does. Not sure how the tests didn't catch this. I guess because its still valid technically. I will see if I can fix that tool then, since it worked so well for everything else.

@wgaylord
Copy link
Contributor

Okay, I will be making a PR with the 1.20.2 data fixed and also adding a test to check that the iron door is not rotated. (Since that is a simple way to catch this.)

rom1504 pushed a commit that referenced this issue Dec 17, 2023
…805)

* Fix 1.20.2 Recipes and add test to check for flipped door

* Fix repices using -1 isntead of null, really need to fix the tool to do that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants