Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting several protocol versions #9

Closed
rom1504 opened this issue Mar 28, 2015 · 6 comments
Closed

Supporting several protocol versions #9

rom1504 opened this issue Mar 28, 2015 · 6 comments

Comments

@rom1504
Copy link
Member

rom1504 commented Mar 28, 2015

The current plan is to support minecraft 1.8.
But at some point 1.9 will be out, and supporting both version might be nice.
How could we support multiple versions ?
Different branches ? Different folders ?

(this is a long-term issue, mainly becoming relevant when 1.9 comes out)

@rom1504
Copy link
Member Author

rom1504 commented Mar 28, 2015

I think different branches would probably be the best, so we can backport thing more easily.

@deathcap
Copy link
Member

How would different branches work on NPM, would there be separate modules minecraft-data-1.8, minecraft-data-1.7, etc., or different major versions of https://www.npmjs.com/package/minecraft-data?

If the latter, this could cause problems with cross-protocol support; since package.json "dependencies" is keyed by module name so only one minecraft-data module could be listed in each package.json. (Though I suppose this could be worked around in the dependent module by creating separate directories with different package.json's adding each specific minecraft-data module version.)

@rom1504
Copy link
Member Author

rom1504 commented Mar 30, 2015

creating separate directories with different package.json's adding each specific minecraft-data module version

yeah this would probably be the plan (because a dependent module might want to support multiple version at the same time ( @roblabla would like to do that in node-minecraft-protocol (when he's done Protocols and node-minecraft-protocol is mainly a .json that can be added to minecraft-data)))
So I guess different major versions.

@rom1504
Copy link
Member Author

rom1504 commented Aug 9, 2015

@rom1504
Copy link
Member Author

rom1504 commented Aug 13, 2015

What has been done here :

  • a branch for each mc version (currently 1.8 and 1.9)
  • no master branch

Next step is fixing PrismarineJS/node-minecraft-data#4

@rom1504
Copy link
Member Author

rom1504 commented Aug 21, 2015

done

@rom1504 rom1504 closed this as completed Aug 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants