Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use minecraft-data as a submodule instead of a dependency #4

Closed
rom1504 opened this issue Aug 6, 2015 · 4 comments
Closed

Use minecraft-data as a submodule instead of a dependency #4

rom1504 opened this issue Aug 6, 2015 · 4 comments

Comments

@rom1504
Copy link
Member

rom1504 commented Aug 6, 2015

That would make minecraft-data more language independent and solve the confusing 2 version of minecraft-data in npm situation.

It would make it possible to have similar python-minecraft-data or languageX-minecraft-data repos providing easy access to minecraft data in languageX.

@rom1504
Copy link
Member Author

rom1504 commented Aug 6, 2015

This would mean removing minecraft-data npm version and having branches in minecraft data :

  • 1.8
  • 1.9

Possible tags like 1.8-0.1.0 1.8-0.2.0 ... if that's useful

In node-minecraft-data you'd have to use these branches somehow and I guess publish several node-minecraft-data versions ?

Maybe version like 1.8-0.1.0 and 1.9-0.1.0 for node-minecraft-data and branches in node-minecraft-data ?

@rom1504
Copy link
Member Author

rom1504 commented Aug 13, 2015

Would it be a good idea to have several minecraft-data submodules in node-minecraft-data, one for each minecraft version and to provide the data for each of these version with node-minecraft-data ?

It might be useful in order to have multiple version compatibility in node-minecraft-protocol and mineflayer.

@rom1504
Copy link
Member Author

rom1504 commented Aug 17, 2015

Remaining to do :

@rom1504
Copy link
Member Author

rom1504 commented Aug 21, 2015

done

@rom1504 rom1504 closed this as completed Aug 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant