remap u32 to varint in protocol.json #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs to be double checked with Burger that these snapshots actually don't use u32 here |
|
I don't think this is correct just add u32 as a native |
|
So all the versions before and after which are varint for that packet, are wrong? |
|
No, likely it only changed for these versions |
looks like this packet was created in the versions in this PR. Can you find any previous version that contains this packet ? |
|
Looking at the decompile for 17w18a, this was an i32. The correct answer is to just switch to i32 which will fix the issue |
|
Updated with i32 @nickelpro @rom1504 |
nickelpro
approved these changes
Aug 16, 2021
rom1504
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#456
remove u32 and replace with varint, per every other protocol version.