Pc1.20.5 protocol #898
Open
Pc1.20.5 protocol #898
+19,444
−840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Extractor is not working correctly per PrismarineJS/minecraft-data-generator-server#23 but i've fixed the issues here manually for now |
|
There are significant changes to the item encoding which involves removing NBT in favor of custom binary encoded "component" data for items. There is still alot of work to do there and it will require some custom types: for example, in block set (https://wiki.vg/Slot_Data#Block_Set) the length of an array is the value of a field - 1. Some work was started in this commit to implement the changes 05a854f Everything needs to be implemented, as we cannot decode an array of slots without being 100% correct in encode/decode as it will break parsing of all following entries in an array. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.