make webserver stoppable once created #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure on whether to merge more things like this here vs merging one of the massive PRs open |
|
do both. |
|
I need it, sometimes I check the bot to see how it is, but I could launch a task if there is no open connection that automatically stops the service, to improve performance/consumption |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the bot starting process includes creating a webserver you can't replay it because the default port is already bound and can't be freed
this pr makes freeing possible by adding a stopServer() method
That's useful if you have to recreate your bot sometimes (possibly due to disconnects) but don't want to recreate the whole node process