-
-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate and rename respawn
option to autoRespawn
#3280
Conversation
respawn
options to autoRespawn
respawn
option to autoRespawn
lib/loader.js
Outdated
@@ -70,7 +70,7 @@ function createBot (options = {}) { | |||
options.loadInternalPlugins = options.loadInternalPlugins ?? true | |||
options.client = options.client ?? null | |||
options.brand = options.brand ?? 'vanilla' | |||
options.respawn = options.respawn ?? true | |||
options.autoRespawn = options.autoRespawn ?? options.autoRespawn ?? true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect logic
Also, the doc seems already pretty clear. Is there anyone that's been confused by this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, fixed
why is it worth it to do such a breaking change for a minor renaming? |
where did you find the breaking change? the pr is here because of #3276 (comment), if for some reason you don't like it feel free to close it... |
Removing the option |
But I didn't remove support for options.respawn, old option should still be supported. am I missing something? |
ah yeah I see, yeah then it's not breaking not sure if it's really useful though, but maybe... |
Closing this so you can prioritize a lot of other more important prs |
fixes #3276