Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAIT_TIME_BEFORE_NEW_JUMP to high #573

Closed
duralakun opened this issue Aug 1, 2017 · 4 comments
Closed

WAIT_TIME_BEFORE_NEW_JUMP to high #573

duralakun opened this issue Aug 1, 2017 · 4 comments

Comments

@duralakun
Copy link

duralakun commented Aug 1, 2017

at:

const WAIT_TIME_BEFORE_NEW_JUMP = 0.3

when using the navigator plugin, it cannot do jumps repeatly, this can be easily fixed
by changing

const WAIT_TIME_BEFORE_NEW_JUMP = 0.3

to

const WAIT_TIME_BEFORE_NEW_JUMP = 0.07

see also:
PrismarineJS/mineflayer-navigate#14

but I don't know if 0.07 is the correct value or if this will break something else

@duralakun duralakun changed the title WAIT_TIME_BEFORE_NEW_JUMP to low WAIT_TIME_BEFORE_NEW_JUMP to high Aug 1, 2017
@roblabla
Copy link
Member

roblabla commented Aug 1, 2017

TBH, instead of "WAIT_TIME_BEFORE_NEW_JUMP, shouldn't we detect when it's safe to jump again internally ? IDK if we have an event like this, but it seems like we should have an on_ground event and jump again in that ? Am I missing something ?

@rom1504
Copy link
Member

rom1504 commented Aug 1, 2017

see #327
and #114

not sure what is the correct fix.

@duralakun
Copy link
Author

duralakun commented Aug 2, 2017

about #114
When i set bot.setControlState('jump', true) the bot will jump continously. Sometimes it looks like it doesnt touch the ground, but i think its just lag and it does actually touch the ground. I let the bot jump for 5 min and it never hurted itself.
Also the WAIT_TIME_BEFORE_NEW_JUMP is lower than 0.7 on the actually client from notch.
When i stand next to the bot and press space, i jump faster than it

So far I couldnt find any bugs or unwanted beahviour after setting

const WAIT_TIME_BEFORE_NEW_JUMP = 0.07

@rom1504
Copy link
Member

rom1504 commented Aug 2, 2017

ok I'm fine with that then

@rom1504 rom1504 closed this as completed in 28cde57 Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants