Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot cannot jump repeatedly #327

Closed
Darthfett opened this issue Aug 31, 2015 · 2 comments
Closed

Bot cannot jump repeatedly #327

Darthfett opened this issue Aug 31, 2015 · 2 comments

Comments

@Darthfett
Copy link
Contributor

When navigating using mineflayer-navigate, the bot is unable to jump as fast as necessary, due to physics.js preventing jumping from happening too quickly: https://github.com/andrewrk/mineflayer/blob/master/lib/plugins/physics.js#L99

This bug causes this: Darthfett/helperbot#41

@rom1504
Copy link
Member

rom1504 commented Aug 31, 2015

Ah, good point !
That check was added to prevent the bot to jump to quickly was added to fix #114 (which it did).
But apparently that's not exactly the correct fix.

We need to find the right way to allow both things to work correctly.

@Darthfett
Copy link
Contributor Author

I wonder if physics.js is setting the bot.entity.onGround too quickly? It
seems like the reason constantly jumping wouldn't work is because the
server doesn't realize we landed.

It would probably be good to look at the positions sent by the Notchian
client and mineflayer client and compare. Maybe we could send a second
position update with the on-ground position when we are supposed to have
landed.
On Aug 30, 2015 8:43 PM, "Romain Beaumont" notifications@github.com wrote:

Ah, good point !
That check was added to prevent the bot to jump to quickly was added to
fix #114
#114 (which it did).
But apparently that's not exactly the correct fix.

We need to find the right way to allow both things to work correctly.


Reply to this email directly or view it on GitHub
#327 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants