Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bot.clickWindow mode disclaimer #2595

Merged
merged 2 commits into from
May 10, 2022
Merged

Conversation

IceTank
Copy link
Contributor

@IceTank IceTank commented Apr 20, 2022

If we are throwing with mode values other then 0 inside the clickWindow function we should also say that in the documentation.

@u9g
Copy link
Member

u9g commented Apr 27, 2022

maybe say to refer to the simpleClick methods

@amoraschi
Copy link
Contributor

Maybe it's also a good idea to print a warning or something when using mode other than 0

@u9g
Copy link
Member

u9g commented May 10, 2022

Maybe it's also a good idea to print a warning or something when using mode other than 0

you can put that in another pr

@u9g u9g merged commit 1847001 into PrismarineJS:master May 10, 2022
@IceTank IceTank deleted the patch-3 branch May 11, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants