Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add player object to blockBreakProgressEnd & observed. #2647

Merged
merged 2 commits into from
Aug 7, 2022

Conversation

JackCrispy
Copy link
Contributor

I needed to see which players were interacting with blocks, shoutout to U9G#0670 on discord for solution.

I needed to see which players were interacting with blocks, shoutout to U9G#0670 on discord for solution.
@amoraschi
Copy link
Contributor

amoraschi commented Jun 2, 2022

Should the variable be renamed to entity? Since I think that returns an entity.

(Also should be added to docs)

JackCrispy added a commit to JackCrispy/mineflayer that referenced this pull request Jun 2, 2022
@JackCrispy
Copy link
Contributor Author

Added to docs.

@IceTank
Copy link
Contributor

IceTank commented Jun 2, 2022

Added to docs.

You added it to the wrong branch. The branch where you changed the docs is named patch-1 but the branch you want to merge into prismarine/master is master.

You should also add this to the index.d.ts file for the typescript typings.

@rom1504 rom1504 added this to Needs triage in PR Triage Aug 7, 2022
@rom1504 rom1504 merged commit b23d040 into PrismarineJS:master Aug 7, 2022
PR Triage automation moved this from Needs triage to Closed Aug 7, 2022
rom1504 pushed a commit that referenced this pull request Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
PR Triage
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

4 participants