Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type on move event #2712

Merged
merged 1 commit into from
Aug 7, 2022

Conversation

sefirosweb
Copy link
Contributor

The position of event move is missing in type

The event of move all time is emited with Vec3 type:

bot.emit('move', oldPos)

bot.emit('move', oldPos)

const oldPos = new Vec3(lastSent.x, lastSent.y, lastSent.z)
lastSent.x = position.x
lastSent.y = position.y
lastSent.z = position.z
lastSent.yaw = yaw
lastSent.pitch = pitch
lastSent.onGround = onGround
bot._client.write('position_look', lastSent)
bot.emit('move', oldPos)

@rom1504 rom1504 added this to Needs triage in PR Triage Aug 7, 2022
@rom1504 rom1504 merged commit 3358e4b into PrismarineJS:master Aug 7, 2022
PR Triage automation moved this from Needs triage to Closed Aug 7, 2022
@sefirosweb sefirosweb deleted the fix_move_type_event branch January 28, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
PR Triage
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants