Player hitbox fixes #3382
Open
Player hitbox fixes #3382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace raytrace start position with bot.entity.eyeHeight Remove old fix for player hitbox height
Set raytrace start position to bot.entity.eyeHeight
Minor typo in comment lol
Change lookAt start position to use bot.entity.eyeHeight
Change canSeeBlock to use bot.entity.eyeHeight
Update player height on crouch/uncrouch
Initialize bot.entity.height and bot.entity.width on login
Initialize bot entity eyeHeight on login
|
Alot of this entity logic should really be moved to prismarine-entity I think over the messy dynamic object extension code at the moment in entity.js. But the present PR seems to be ok. |
Fix typescript types syntax for setCommandBlock (PrismarineJS#3366)
extremeheat
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize width and height on the bot entity during login
Add eyeHeight property to the bot entity, which updates on crouch/uncrouch
Change raytracing and visibility functions to use bot.entity.eyeHeight instead of bot.entity.height