Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.19.0 release: Error: Cannot find module './minecraft-data/data/common/protocolVersions' #16

Closed
deathcap opened this issue Feb 1, 2016 · 2 comments

Comments

@deathcap
Copy link
Member

deathcap commented Feb 1, 2016

When installing the 0.19.0 release of minecraft-data from from npm, require() fails:

tmp $ npm install minecraft-data
minecraft-data@0.19.0 node_modules/minecraft-data
tmp $ node
> require('minecraft-data')
Error: Cannot find module './minecraft-data/data/common/protocolVersions'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:289:25)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (/private/tmp/node_modules/minecraft-data/index.js:3:22)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:313:12)
    at Module.require (module.js:366:17)

see also https://circleci.com/gh/PrismarineJS/node-minecraft-protocol/371 - observed when updating in PrismarineJS/node-minecraft-protocol#331

using the git version of node-minecraft-data (https://github.com/PrismarineJS/node-minecraft-data/tree/4e7f910e62ea30c641a9df2170275d49bbd1edad) with npm install works locally at least on my system, so I think this is an issue with the release only

@deathcap
Copy link
Member Author

deathcap commented Feb 1, 2016

0.17.0 and earlier (npm install minecraft-data@0.17; find node_modules) contain the minecraft-data submodule, but 0.18.0 and 0.19.0 are missing it

deathcap added a commit to deathcap/node-minecraft-protocols that referenced this issue Feb 1, 2016
deathcap added a commit to deathcap/node-minecraft-protocol that referenced this issue Feb 1, 2016
deathcap added a commit to deathcap/node-minecraft-protocol that referenced this issue Feb 1, 2016
deathcap added a commit to deathcap/node-minecraft-protocols that referenced this issue Feb 1, 2016
deathcap added a commit to deathcap/node-minecraft-protocol that referenced this issue Feb 1, 2016
deathcap added a commit to deathcap/node-minecraft-protocol that referenced this issue Feb 1, 2016
@rom1504 rom1504 closed this as completed in 3050ed4 Feb 1, 2016
@rom1504
Copy link
Member

rom1504 commented Feb 1, 2016

My bad. I was cloning the repo to work around npm/npm#5673 (comment) and I forgot to --recursive.
Fixed in 0.19.1 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants