Fix handling of disconnect in versionChecking on 1.20.3+. (#1291)

* Fix handling of disconnect in versionChecking on 1.20.3+. Also handle newer translate string used in 1.20.2+

* Comments why we ignore PLAY and CONFIGURATION state disconnects, and un-inline an if

* Add extra comment on why we are ignoring those states.

* Change bitwise or to logical or

src/client/versionChecking.js

@@ -1,6 +1,11 @@
+const states = require('../states')
+
 module.exports = function (client, options) {
   client.on('disconnect', message => {
     if (!message.reason) { return }
+    // Prevent the disconnect packet handler in the versionChecking code from triggering on PLAY or CONFIGURATION state disconnects
+    // Since version checking only happens during that HANDSHAKE / LOGIN state.
+    if (client.state === states.PLAY || client.state === states.CONFIGURATION) { return }
     let parsed
     try {
       parsed = JSON.parse(message.reason)
@@ -11,7 +16,9 @@ module.exports = function (client, options) {
     let text = parsed.text ? parsed.text : parsed
     let versionRequired
 
-    if (text.translate && text.translate.startsWith('multiplayer.disconnect.outdated_')) { versionRequired = text.with[0] } else {
+    if (text.translate && (text.translate.startsWith('multiplayer.disconnect.outdated_') || text.translate.startsWith('multiplayer.disconnect.incompatible'))) {
+      versionRequired = text.with[0]
+    } else {
       if (text.extra) text = text.extra[0].text
       versionRequired = /(?:Outdated client! Please use|Outdated server! I'm still on) (.+)/.exec(text)
       versionRequired = versionRequired ? versionRequired[1] : null