Implement 1.19.2 chat signing

[rom1504]

From @kashalls

[rom1504]

https://github.dev/extremeheat/extracted_minecraft_data/blob/client1.19.1/client/net/minecraft/client/multiplayer/ClientPacketListener.java#L2308-L2309 ServerboundChatAckPacket sent from client -> server every 64 messages they recieve ; server can then process the ACKs and kick client ...https://github.dev/extremeheat/extracted_minecraft_data/blob/client1.19.1/client/net/minecraft/server/network/ServerGamePacketListenerImpl.java#L1454 for reasons in enum at https://github.dev/extremeheat/extracted_minecraft_data/blob/client1.19.1/client/net/minecraft/network/chat/LastSeenMessagesValidator.java#L128

From @extremeheat

[rom1504]

https://youtu.be/wn6fBvW4WOg?t=100 relevant video

[rom1504]

High level:

• Keep N last messages
• use that to produce a signature to send message
• expose that as a function in NMP
• use in examples and in mineflayer

[rom1504]

https://github.com/PrismarineJS/prismarine-auth/pull/65/files related

[rom1504]

ideas to go forward here:

• dig into mc java code
• use https://github.com/PrismarineJS/node-minecraft-protocol/tree/master/examples/proxy to get some examples of chat packet
• help define the right API

[rom1504]

More ideas:

• Check if anyone else implemented it and do the same

[rom1504]

https://gist.github.com/kennytv/ed783dd244ca0321bbd882c347892874

From azalea-rs/azalea#51 (comment)

[rom1504]

https://github.com/adepierre/Botcraft/blob/master/botcraft/src/Network/NetworkManager.cpp#L172-L206

https://github.com/adepierre/Botcraft/blob/master/botcraft/src/Network/Authentifier.cpp#L288

From adepierre/Botcraft#102 (comment)

[extremeheat]

Some links to the minecraft java source for clientbound chat handling, not including verification :

• When a player message packet is received by the client, this handler is run in ClientPacketListener: https://github.dev/extremeheat/extracted_minecraft_data/blob/client1.19.1/client/net/minecraft/client/multiplayer/ClientPacketListener.java#L768 (if the message type doesn't exist in the dimension codec sent in the login packet, then the message is dropped as the client can't format it)
• If the message is valid, runs handleChatMessage() in nmc.multiplayer.chat.ChatListener
  • if a received client chat message has a profileId of NULL in the ClientboundPlayerChatPacket packet, it's read as a system message
  • handleMessage is a throttle (maybe to prevent chat flooding lag?), otherwise accept() is called immediately
  • if ClientboundDeleteChatPacket is sent by the server, chat message is removed and removeIfSignatureMatches is called in ChatListener to handle the case that a message is removed while in the throttle queue -- if this happens, the header is processed then pushed to chat history and the message will be removed from the queue before it's shown to user. If the message was already shown, it's just removed from the GUI
• after an clientbound message is accept()'ed, in processPlayerChatMessage it's verified
• it's then pushed to the chat reporting log
• after that it's pushed to the recent message queue, the smaller non-reporting one -- only 5 messages wide
  • every 64 messages the client should send an acknowledgements to the server -- to which the server will process and kick if there is desync

[rom1504]

PrismarineJS/prismarine-auth#65 for the reporting payload which is similar to what nmp will need to store in memory

from extremeheat

[rom1504]

d27da69 wip from @u9g

[rom1504]

This issue is funded at $150

[rom1504]

Thanks @frej4189 and @extremeheat for solving this one!

As agreed with extremeheat, granting the $150 to @frej4189

[rom1504]

relevant PRs
#1049
#1052
#1050