Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 1.19.1/1.19.2 #2797

Closed
JIBSIL opened this issue Oct 13, 2022 · 17 comments · Fixed by #2894
Closed

Support 1.19.1/1.19.2 #2797

JIBSIL opened this issue Oct 13, 2022 · 17 comments · Fixed by #2894
Labels
new feature Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f

Comments

@JIBSIL
Copy link

JIBSIL commented Oct 13, 2022

Is your feature request related to a problem? Please describe.

Would it be possible to upgrade Mineflayer from Protocol Version 759 to Protocol Version 760? (1.19 to 1.19.1/1.19.2)

Describe the solution you'd like

Probably the main change would be secure chat here as 1.19 changes are already implemented

Additional context

n/a

@JIBSIL JIBSIL added new feature Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f labels Oct 13, 2022
@will2022
Copy link

@rom1504
Copy link
Member

rom1504 commented Oct 13, 2022

Yeah need the protocol in mcdata and then this can be done
Probably not a big change but your contribution would be appreciated

@IssueHuntBot
Copy link

@jtsiskin has funded $30.00 to this issue.


@rom1504
Copy link
Member

rom1504 commented Oct 25, 2022 via email

@Fruce
Copy link

Fruce commented Oct 28, 2022

mineflayer not working for 1.19.1 or 1.19.2

@AnyBananaGAME
Copy link

Those versions are not supported yet

@IssueHuntBot
Copy link

@jtsiskin has cancelled funding for this issue.(Cancelled amount: $30.00) See it on IssueHunt

@iska69
Copy link

iska69 commented Nov 4, 2022

When does the big hacker people that read this say that they think this is going to be done?

@Killjoyer
Copy link

temporary fix (kinda) if you don't need chat at all and just frustrate from constat crushes - you can edit library locally - node_modules/mineflayer/lib/loader.js -> comment line 12 (chat: require...)

@rom1504
Copy link
Member

rom1504 commented Dec 2, 2022

@rom1504 rom1504 pinned this issue Dec 2, 2022
@rom1504 rom1504 mentioned this issue Dec 2, 2022
@extremeheat extremeheat changed the title 1.19.1/1.19.2 Support 1.19.1/1.19.2 Jan 1, 2023
@Le0X8
Copy link

Le0X8 commented Jan 11, 2023

How long will it take to fix this?

Need 1.19.2 for a project

@AnyBananaGAME
Copy link

How long will it take to fix this?

Need 1.19.2 for a project

Well, the community is trying to update it so there is no ETA.

@rom1504
Copy link
Member

rom1504 commented Jan 14, 2023

now nmp has 1.19.2

so need to make a PR for mineflayer here

see changes to do at PrismarineJS/node-minecraft-protocol#1050 (comment)

@rom1504
Copy link
Member

rom1504 commented Jan 14, 2023

@extremeheat
Copy link
Member

extremeheat commented Jan 17, 2023

@AnyBananaGAME @Le0X8

#2894 adds 1.19.2 with chat support, if anyone wants to test that it's working (specifically non-vanilla servers would be notable)
(install PR with npm install https://github.com/frej4189/mineflayer#new-chat)

@wullie111
Copy link

wullie111 commented Jan 17, 2023

@AnyBananaGAME @Le0X8

#2894 adds 1.19.2 with chat support, if anyone wants to test that it's working (specifically non-vanilla servers would be notable) (install PR with npm install https://github.com/frej4189/mineflayer#new-chat)

I am testing it across the py bridge and i am receiving this error when the bot say anything in chat version 1.19.2 modded fabric
(no chat report )
image

@rom1504
Copy link
Member

rom1504 commented Jan 19, 2023

done

@rom1504 rom1504 reopened this Jan 19, 2023
@rom1504 rom1504 closed this as completed Jan 19, 2023
@rom1504 rom1504 unpinned this issue Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f
Projects
None yet
Development

Successfully merging a pull request may close this issue.