Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client ID is missing from typings. #818

Closed
steven-peralta opened this issue Feb 14, 2021 · 2 comments
Closed

Client ID is missing from typings. #818

steven-peralta opened this issue Feb 14, 2021 · 2 comments

Comments

@steven-peralta
Copy link

When trying to reference Client.id in a Typescript project, you get the error Property 'id' does not exist on type 'Client'. because it is missing from the Client typings. There should be an optional id property here representing the client id.
@steven-peralta
Copy link
Author

also the key type of ClientsMap is a string which doesn't make sense because the id of the client is always set to be an incrementation of nextId in Server#listen

u9g added a commit to u9g/node-minecraft-protocol that referenced this issue Mar 29, 2021
@u9g
changed clientsmap and client
7d71db6 
implements (and closes) PrismarineJS#818
@u9g u9g mentioned this issue Mar 29, 2021
Merged
rom1504 pushed a commit that referenced this issue Mar 29, 2021
@u9g
changed clientsmap and client (#836)
4aaa837 
implements (and closes) #818
@u9g
Copy link
Member

u9g commented Mar 29, 2021

can be closed, added in #836

@rom1504 rom1504 closed this as completed Mar 29, 2021
matthi4s pushed a commit to aternosorg/node-minecraft-protocol that referenced this issue Jun 9, 2021
@u9g @matthi4s
changed clientsmap and client (PrismarineJS#836)
eceb29c 
implements (and closes) PrismarineJS#818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steven-peralta @rom1504 @u9g