Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MCLeaks support #572

Closed
wants to merge 1 commit into from
Closed

Add MCLeaks support #572

wants to merge 1 commit into from

Conversation

funniray
Copy link

@funniray funniray commented Jul 10, 2018

This is all that's needed for MCLeaks to work. Here's how you would authenticate (Side note, this requires my fork of node-mcleaks)

const options = {
    username: "MCLeaks", //You have to put something here
    mcLeaks: true,
    token: "huidfshdfushsdf" //Your MCLeaks token
};
    mcleaks.redeem(options, function (err, data) { //options.token should be defined
        if (err) {
            log("Something went wrong with mcLeaks authentication.");
            throw err;
        }
        options.session = {
            accessToken: data.result.session,
            selectedProfile: {
                name: data.result.mcname
            }
        };
        options.token = undefined;
        cb(mineflayer.createBot(options));
    });

@rom1504
Copy link
Member

rom1504 commented Jul 10, 2018

Hi,
No, let's not add mcleaks as a dependency.
You can probably change nmp to add an option to do what you want without actually putting the mcleaks code in nmp

@SuperOP535
Copy link

yeah, i dont know if nmp supports plugins but that'd be a good idea

@funniray
Copy link
Author

Yeah, if adding plugins was possible (for logging in and such) were possible, then I would do that. I'm just not sure of the best way to do this currently.

@roblabla
Copy link
Member

joinServerRequest(onJoinServerResponse)
Could take joinServerRequets in the options ?

@rom1504
Copy link
Member

rom1504 commented Aug 3, 2018

please re-open / recreate one with something generic

@rom1504 rom1504 closed this Aug 3, 2018
@leahcornelius
Copy link

Hey, sorry to necro. WIll this still work?

@funniray
Copy link
Author

funniray commented Feb 12, 2021

Probably, but you would have to patch it in yourself for newer versions of minecraft-protocol-node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants