generated from PrismarineJS/prismarine-template
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for hashed block network ID's #33
Open
FreezeEngine
wants to merge
12
commits into
PrismarineJS:master
Choose a base branch
from
FreezeEngine:blockstate-hashes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8ab82dc
Addeed calculateBlockStateHashes function
irkmandeer ba91423
Fixed minecraft:unknown
irkmandeer f1c9567
Added handleStartGame, moved hashing to pblock
FreezeEngine f5ec608
Fixes
FreezeEngine 6ffd6bd
Added block.stateId to blocksByRuntimeId
FreezeEngine b415fbc
Simplified loadHashedRuntimeIds
FreezeEngine 7598a41
Remove unrelated code
FreezeEngine 6e2d40b
blocksByRuntimeId to include stateId
FreezeEngine 893bf24
small fix
FreezeEngine 1f2453b
Removed exposure of helper functions
FreezeEngine 6f077c6
Revert "Removed exposure of helper functions"
FreezeEngine e99a3f7
Removed exposure of helper functions in return
FreezeEngine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
const buildIndexFromArray = require('../indexer') | ||
module.exports = (registry, data) => { | ||
return { | ||
loadItemStates (itemStates) { | ||
const items = [] | ||
for (const item of itemStates) { | ||
const name = item.name.replace('minecraft:', '') | ||
items.push({ ...data.itemsByName[name], name, id: item.runtime_id }) | ||
} | ||
data.itemsArray = items | ||
data.items = buildIndexFromArray(data.itemsArray, 'id') | ||
data.itemsByName = buildIndexFromArray(data.itemsArray, 'name') | ||
}, | ||
|
||
loadHashedRuntimeIds () { | ||
const Block = require('prismarine-block')(registry) | ||
data.blocksByRuntimeId = {} | ||
for (let i = 0; i < data.blockStates.length; i++) { | ||
const { name, states } = data.blockStates[i] | ||
const hash = Block.getHash(name, states) | ||
data.blocksByRuntimeId[hash] = { stateId: i, ...data.blocksByStateId[i] } | ||
} | ||
}, | ||
|
||
loadRuntimeIds () { | ||
data.blocksByRuntimeId = {} | ||
for (let i = 0; i < data.blockStates.length; i++) { | ||
data.blocksByRuntimeId[i] = { stateId: i, ...data.blocksByStateId[i] } | ||
} | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean put the non-API helper functions before this return statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also if you make a change to the PR that needs review, feel free to comment so we can get notified of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! Thank you, will note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might've done it