Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct tint for blocks #25

Closed
Karang opened this issue Jul 17, 2020 · 2 comments
Closed

Correct tint for blocks #25

Karang opened this issue Jul 17, 2020 · 2 comments
Labels
new feature rendering

Comments

@Karang
Copy link
Collaborator

Karang commented Jul 17, 2020 •
edited

Block tint depends on the type of block and for some blocks on the biome.
The correct colors for each combinations are listed here:
https://minecraft.gamepedia.com/Tint

Tint is currently hardcoded to plain grass green for blocks:
https://github.com/PrismarineJS/prismarine-viewer/blob/master/viewer/lib/models.js#L232

And to ocean blue for water:
https://github.com/PrismarineJS/prismarine-viewer/blob/master/viewer/lib/models.js#L106
@rom1504
Copy link
Member

rom1504 commented Mar 16, 2021

https://github.com/PrismarineJS/minecraft-wiki-extractor might be useful for any contributor interested on this

@rom1504 rom1504 pinned this issue Mar 16, 2021
@Karang
Copy link
Collaborator Author

Karang commented Mar 17, 2021

Done

@Karang Karang closed this as completed Mar 17, 2021
@Karang Karang unpinned this issue Mar 17, 2021
@AwesomestCode AwesomestCode mentioned this issue Jun 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature rendering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Karang @rom1504