Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import all good changes from zardoy fork #420

Open
rom1504 opened this issue Dec 31, 2023 · 10 comments
Open

import all good changes from zardoy fork #420

rom1504 opened this issue Dec 31, 2023 · 10 comments

Comments

@rom1504
Copy link
Member

rom1504 commented Dec 31, 2023

https://github.com/zardoy/prismarine-web-client/commits/main/prismarine-viewer

@rom1504
Copy link
Member Author

rom1504 commented Dec 31, 2023

first thing is migrating to esbuild to speed up builds by a lot

@zardoy
Copy link
Contributor

zardoy commented Dec 31, 2023

btw just asking, would it be possible to implement changelogging in github releases like in repo mentioned above? like reading them github releases from mobile

@rom1504
Copy link
Member Author

rom1504 commented Dec 31, 2023

@zardoy
Copy link
Contributor

zardoy commented Jan 1, 2024

Yes but also include it into release body as text

@rom1504
Copy link
Member Author

rom1504 commented Jan 1, 2024

could be implemented by changing https://github.com/PrismarineJS/prismarine-template/blob/master/.github/workflows/publish.yml and https://github.com/PrismarineJS/prismarine-repo-actions

but I don't really see a lot of point to it, history.md works well

@zardoy
Copy link
Contributor

zardoy commented Jan 1, 2024

@extremeheat
Copy link
Member

Could be done with a script in the repo to read the README.md / HISTORY.md and pipe to the release action's body. Or just adding a link to the HISTORY.md or README.md's changelog section could work too.

@rom1504
Copy link
Member Author

rom1504 commented Jan 1, 2024

Could be done with a script in the repo to read the README.md / HISTORY.md and pipe to the release action's body

yeah that's more or less what https://github.com/evanw/esbuild/blob/main/.github/workflows/release.yml#L20 do

feel free to try adapting that to our https://github.com/PrismarineJS/prismarine-template/blob/master/.github/workflows/publish.yml @zardoy

@IssueHuntBot
Copy link

@zardoy has funded $10.00 to this issue.


@varshith257
Copy link

varshith257 commented Apr 17, 2024

@rom1504 @zardoy is it yet open to work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants