Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It swears at the nodejs version, and this is in the browser. How so? #356

Closed
lastuniverse opened this issue Dec 24, 2023 · 9 comments
Closed

It swears at the nodejs version, and this is in the browser. How so? #356

lastuniverse opened this issue Dec 24, 2023 · 9 comments

Comments

@lastuniverse
Copy link

image
@ZXMushroom63
Copy link

I reckon it's this line of code:
https://github.com/PrismarineJS/prismarine-web-client/blob/master/index.js#L26

@zardoy
Copy link
Contributor

zardoy commented Dec 25, 2023

Duplicate of #349 ?

@rom1504
Copy link
Member

rom1504 commented Dec 25, 2023

Please fix

@lastuniverse
Copy link
Author

I can't fix it. I don't install this package locally. I just followed the link on the main page of the repository.

Live demo at https://prismarinejs.github.io/prismarine-web-client/

@rom1504
Copy link
Member

rom1504 commented Dec 29, 2023 via email

@ZXMushroom63
Copy link

Duplicate of #349 ?

Yep.

@zardoy
Copy link
Contributor

zardoy commented Dec 31, 2023

Duplicate of #349 ?

Yep.

Good! 👍

@rom1504
Copy link
Member

rom1504 commented Dec 31, 2023

fixed

now need to fix #357 to redeploy

@rom1504
Copy link
Member

rom1504 commented Dec 31, 2023

fixed

@rom1504 rom1504 closed this as completed Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rom1504 @lastuniverse @zardoy @ZXMushroom63