-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(next.js): Migration to next.js #68
Conversation
Socket Security Pull Request ReportDependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again. 📞 TelemetryThis package contains telemetry which tracks you.
Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with
Powered by socket.dev |
CI failing |
MMM it's about telemetry data. What do you thinks? |
To merge I propose to use squash and merge |
Review is ready ! |
CI failing |
This doesn't seem to bring any new features |
IDK why? Because I have add .env with telemetry at off and add socket file to with ignore the package. |
Technically it's just the migration.
|
They are feat added:
|
Can you do the last review ? And do this |
blocked on adding any new feature (can be done in other PRs) |
this increases the complexity I think we should rather decrease it |
It increases the complexity a bit. But it also increases the DX and stability. |
Oups fail for closing |
apparently it was not clear in my previous messages: if there is no feature added, I think we should not move to next.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's Good
why was this closed |
Introduce Next.js
Sadly, it's not really the same in style. but in content it's same.
After merge of this pr I will improve the project.
Implement next.js help to maintain the website
feature added
feature can be add in futur
Related Issue
#67