Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(next.js): Migration to next.js #68

Closed
wants to merge 20 commits into from
Closed

Feat(next.js): Migration to next.js #68

wants to merge 20 commits into from

Conversation

AugustinMauroy
Copy link

@AugustinMauroy AugustinMauroy commented Feb 9, 2023

Introduce Next.js

Sadly, it's not really the same in style. but in content it's same.

After merge of this pr I will improve the project.

don't worry!

Implement next.js help to maintain the website

feature added

  • Typescript support
  • Twitter link
  • Discord link
  • Icon for link
  • Dark mode
  • Linter
  • Code format
  • 404 page
  • Sass support

feature can be add in futur

It's not for this pr it's for after merging

  • I18n support
  • Markdown support
  • Unit test

Related Issue

#67

@socket-security
Copy link

socket-security bot commented Feb 9, 2023

Socket Security Pull Request Report

Dependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again.

📞 Telemetry

This package contains telemetry which tracks you.

Package Note Source
next@13.2.1 (added) Can be disabled by setting the environment variable NEXT_TELEMETRY_DISABLED=1 package-lock.json, package.json
Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ⚠️ 1 issue
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore next@13.2.1

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

package.json Outdated Show resolved Hide resolved
@rom1504
Copy link
Member

rom1504 commented Feb 10, 2023

CI failing

@AugustinMauroy
Copy link
Author

AugustinMauroy commented Feb 10, 2023

CI failing

MMM it's about telemetry data. What do you thinks?
nextjs info

@AugustinMauroy
Copy link
Author

To merge I propose to use squash and merge

@AugustinMauroy
Copy link
Author

AugustinMauroy commented Feb 11, 2023

Review is ready !

@rom1504

@rom1504
Copy link
Member

rom1504 commented Feb 12, 2023

CI failing

@rom1504
Copy link
Member

rom1504 commented Feb 12, 2023

This doesn't seem to bring any new features
What's the plan on this ?

@AugustinMauroy
Copy link
Author

CI failing

IDK why? Because I have add .env with telemetry at off and add socket file to with ignore the package.
So idk.

@AugustinMauroy
Copy link
Author

This doesn't seem to bring any new features
What's the plan on this ?

Technically it's just the migration.

  • In long terme I will add one page for one project.
  • Support I18n
  • Add blog/post (for example: realease note)

@AugustinMauroy
Copy link
Author

AugustinMauroy commented Feb 12, 2023

They are feat added:

  • Typescript support
  • discord link
  • twitter link

@AugustinMauroy
Copy link
Author

@rom1504

Can you do the last review ?

And do this @SocketSecurity ignore next@13.1.6

@rom1504 rom1504 added this to Needs triage in PR Triage Mar 4, 2023
@rom1504
Copy link
Member

rom1504 commented Mar 4, 2023

blocked on adding any new feature (can be done in other PRs)

@rom1504 rom1504 moved this from Needs triage to Waiting for user input in PR Triage Mar 4, 2023
@rom1504
Copy link
Member

rom1504 commented Apr 8, 2023

this increases the complexity

I think we should rather decrease it

@AugustinMauroy
Copy link
Author

It increases the complexity a bit. But it also increases the DX and stability.

PR Triage automation moved this from Waiting for user input to Closed Apr 8, 2023
@AugustinMauroy AugustinMauroy reopened this Apr 8, 2023
@AugustinMauroy
Copy link
Author

Oups fail for closing

@rom1504
Copy link
Member

rom1504 commented Apr 8, 2023

apparently it was not clear in my previous messages: if there is no feature added, I think we should not move to next.js

Copy link

@Hardel-DW Hardel-DW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's Good

@AugustinMauroy AugustinMauroy deleted the feat(next.js) branch May 29, 2023 15:08
@kotinash
Copy link

why was this closed

@AugustinMauroy
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
PR Triage
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

4 participants