-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation warnings on Clojure 1.7 #83
Comments
@sritchie I have the same issue. Did you manage to solve it? |
Downgrading |
Well, it's coming in from the macro definition (on my phone now, so can't link). Check the line the error references, then see the definition of that macro. — On Sat, Oct 4, 2014 at 4:08 PM, Carlos Cunha notifications@github.com
|
There's nothing in that line as I have mentioned before. Maybe it's spurious. Not even sure it had any impact in my app. |
Okay, back at my computer. At line 37, that warning comes in because of the macroexpansion of Here's the code for https://github.com/Prismatic/dommy/blob/master/src/dommy/macros.clj#L155 So that line gets expanded to There's no actual error when you run your program if, down the road, some other file requires dommy.template. The solution would be to require |
Thanks for the in-depth investigation.
So this is a problem with the compiler. But polluting the codebase with requires for every similar problem doesn't seem correct, imo. I prefer to not the use that compiler version until the issue is fixed. |
Sure, fine by me. Closing. |
It's not clear to me that this is a compiler bug. The compiler has been recently enhanced to catch more issues so it might be the case here. |
I understand from the response to this question that the Maybe this issue should be reopened? |
This is not a ClojureScript compiler bug. It should be documented in the library what dependencies are implied by macro usage. |
When I try to compile cljs with Clojure 1.7, I see a bunch of warnings like this:
WARNING: Use of undeclared Var dommy.template/->node-like at line 37 file:/Users/sritchie/.m2/repository/prismatic/dommy/0.1.3/dommy-0.1.3.jar!/dommy/attrs.cljs
I'm guessing that requiring
dommy.template
in that namespace will fix this up.The text was updated successfully, but these errors were encountered: