Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize order by #67

Merged
merged 8 commits into from
Apr 28, 2016
Merged

Optimize order by #67

merged 8 commits into from
Apr 28, 2016

Conversation

s-taylor
Copy link
Contributor

@s-taylor s-taylor commented Apr 28, 2016 •
edited
Loading

This PR...

  • adds tests for the .addTransformations function
  • optimises orderBy so that it uses indexes if available
  • now properly detects when a query cannot be converted to a changefeed and uses Dave's workaround accordingly, https://rethinkdb.com/docs/changefeeds/javascript/. Previously I was trying to detect if the query was optimised (using indexes), this instead just mimics exactly what rethink will / wont allow with change feeds and acts accordingly.
  • changes the getIndex function into a getIndexes function, so that we can determine if the orderBy field is indexed.

This PR resolves issue #56

@s-taylor s-taylor changed the title Optimize sort by Optimize order by Apr 28, 2016
@nwinch
Copy link
Contributor

nwinch commented Apr 28, 2016

LGTM 👍

@s-taylor s-taylor merged commit ae048ee into master Apr 28, 2016
@s-taylor s-taylor deleted the optimize-sortBy branch April 28, 2016 23:44
@nwinch nwinch mentioned this pull request Apr 29, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@s-taylor @nwinch