Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direclink get image, new Instance and better url #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

py7hon
Copy link

@py7hon py7hon commented Dec 8, 2023

Thanks for making this project.

I want to give contribution host the instance and add feature like get direct image ex localhost:2034/123.png and i making url better without /en/.

@py7hon
Copy link
Author

py7hon commented Dec 8, 2023

Updated support multi illust image
example :
localhost/114027629-1.jpg
localhost/114027629-2.jpg

@PrivacyDevel
Copy link
Owner

Thank you for your contribution!

  1. The /en/ part should become optional eventually. But completely removing it and breaking links seems like a bad idea.
  2. Json endpoints would be nice as an opt-in feature that can be turned on in the config file but inviting bots with publicly accessible Json endpoints by default seems a bit risky.
  3. Simple image proxying via Python would make it less dependent on an additional reverse proxy but the way it is implemented here is likely going to prevent both client- and server-side caching from working.

Because of all of this, I am probably not going to merge this PR, at least not the way it is right now.
If you decide to work on one or more of those things, it would be great if you could split those changes into separate PRs in the future.

But I am gladly going to add your instance to the instance list :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants