Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64 docker image borked fixing #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

slikie
Copy link

@slikie slikie commented Jun 25, 2023

#9 didn't consider arm64 builds uses Dockerfile.arm64.
This PR will stop producing ghcr.io/privacydevel/nitter:master but use ghcr.io/privacydevel/nitter:latest and :latest-arm64 like upstream.
Note that with QEMU building with nim will take a long time, ~40 minutes. While upstream actions are using paid arm workers so it's way faster.

@slikie slikie closed this Jul 2, 2023
@PrivacyDevel
Copy link
Owner

Why did you close this PR?

@slikie
Copy link
Author

slikie commented Jul 7, 2023

I sent the PR with the wrong branch.

* Update build-publish-docker.yml

* Update build-publish-docker.yml
@slikie
Copy link
Author

slikie commented Apr 10, 2024

tested and still works. feel free to squash and merge at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants