Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSP sandbox #168

Closed
5 of 6 tasks
rugk opened this issue Jan 31, 2017 · 4 comments
Closed
5 of 6 tasks

Use CSP sandbox #168

rugk opened this issue Jan 31, 2017 · 4 comments
Assignees

Comments

@rugk
Copy link
Member

rugk commented Jan 31, 2017

See https://scotthelme.co.uk/csp-cheat-sheet/#sandbox

So what do we need?

  • allow-forms
  • allow-same-origin
  • allow-scripts
  • allow-top-navigation
  • allow-popups
  • allow-pointer-lock

Can you confirm this, @elrido?

@elrido
Copy link
Contributor

elrido commented Feb 1, 2017

I am quite sure we need almost all of them, so the sandbox directive seems quite pointless for our project.

@elrido elrido assigned rugk and unassigned elrido Feb 1, 2017
@rugk
Copy link
Member Author

rugk commented Feb 1, 2017

I've already ticked the one we need, …
They should be the minority. At least we do not need the last three.

@elrido
Copy link
Contributor

elrido commented Feb 1, 2017

We do use pop-ups (in the page template).

I suspect that sandboxing would break many of our use cases, as:

The sandbox applies a same origin policy, prevents popups, plugins and script execution is blocked.

Source: https://content-security-policy.com/

This would, among other things, break password managers.

@rugk rugk closed this as completed in e9b10f9 Feb 1, 2017
@rugk
Copy link
Member Author

rugk commented Feb 1, 2017

So I could basically confirm your requirements. Popus are required for the page theme (password entry) and forms are required for the password entry in the bootstrap theme.
I could not confirm that it would break password managers (tried it with FF internal one) and I also do not see why it should. Maybe give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants