Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title is URL in raw mode #187

Closed
rugk opened this issue Feb 17, 2017 · 2 comments · Fixed by #180
Closed

Title is URL in raw mode #187

rugk opened this issue Feb 17, 2017 · 2 comments · Fixed by #180
Assignees
@rugk
Labels
UI/UX
Projects
Release 1.2 - JavaScript refactoring ...
Milestone
Release 1.2 - Jav...

Comments

@rugk
Copy link
Member

rugk commented Feb 17, 2017

When a paste is viewed in the RAW mode, the title of the window is the URL, which might not be preferably…

Possibly it should stay "PrivateBin".
@rugk rugk added the UI/UX label Feb 17, 2017
@elrido
Copy link
Contributor

elrido commented Feb 17, 2017 •
edited
Loading

I bet this is due to the pushState:

PrivateBin/js/privatebin.js

Line 1408 in dd721c6

null, document.title, helper.scriptLocation() + '?' +

According to docs, the second param should be the title. Maybe we need to set an empty state object for the first parameter instead of null?

@rugk
Copy link
Member Author

rugk commented Feb 17, 2017

And according to the docs "Firefox currently ignores this parameter". The title parameter does not matter at all. Also we do not use the object.

I think the reason is just that we replace the whole content on the site and thereby also remove the header title information.
When you save the site after clicking on the RAW button, this is what you get:

<html><head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8"></head><body><pre>fsdf</pre></body></html>

Obviously no title-information here, so browsers show the URL.

We maybe should just replace body instead of the whole document. I'll try it out…

@rugk rugk self-assigned this Feb 17, 2017
@rugk rugk mentioned this issue Feb 17, 2017
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rugk rugk

Labels
UI/UX
Projects
No open projects
Release 1.2 - JavaScript refactoring ...
  
Done
Milestone
Release 1.2 - JavaScript refactoring ...
Development

Successfully merging a pull request may close this issue.

JS refactoring with revealing module pattern PrivateBin/PrivateBin
2 participants
@elrido @rugk