Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh discussion page every 10 seconds #214

Open
kidburglar opened this issue Apr 6, 2017 · 1 comment
Open

Refresh discussion page every 10 seconds #214

kidburglar opened this issue Apr 6, 2017 · 1 comment

Comments

@kidburglar
Copy link

Hello,

I don't think it's already purposed but I think that it would be nice to have an automatic refresh for discussion page so we not need refresh it manually.

I did some search and it look it's possible to do it without javascript.

I tried it on a test instance and it work but if I add it in bootstrap.php it refresh on all pages.
I would try to reduce it to only refresh the discussion page.

If someone have a tips how recognize discussion page from normal page I will try to make a PR.
Cheers.

@elrido elrido added the UI/UX label Apr 7, 2017
@elrido elrido added this to the Release 1.4 - improved UI milestone Apr 7, 2017
@elrido
Copy link
Contributor

elrido commented Apr 7, 2017

As a quick hack, you may just add the JS based refresh with a timeout in the decryptComments method of the PasteDecrypter object, which only gets called when displaying a paste with comments. This still has the downside that on password protected pastes you have to type in the password over and over again.

For a PR I would prefer a proper solution. If we had the comment pagination feature as outlined in #5 we could use that to easily poll the server for new comments be requesting the last page only and updating the comment list on-page (=without refresh), if needed. Hence I label this request for the same milestone as #5.

@rugk rugk changed the title Refresh discussion page each 10 seconds Refresh discussion page every 10 seconds May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants