-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customization improvements (name, tagline, logo, favicon) #639
Comments
Agree, sounds like a bug.
Good idea.
Yeah, as long as these are easy to implement, I agree and tend to say these are all useful.
I agree. I mean technically we have great customizability – the greatest you can have with editing the PHP template –, but your arguments regarding easier upgrades are totally valid. But we don't really know why people don't upgrade from v1.2 e.g.. 🤔 |
Maybe I will give it a whirl if I get some time. I haven't touched PHP in over a decade. I don't think it would be too much work. They pretty much all amount to "if set, use custom, if unset, use default". The custom CSS styling would just be the last CSS file loaded, so it would override any same-named classes automatically. This is how Stylish handles theming, as does protonmail. It's very simple to make themes using browser's inspector tool this way, and keeps all the theme files detached from the source code. Thanks for the feedback 👍 |
Just a short addendum:
This is implemented deliberately in that way, as the intent is for the software name to be replaced in all instances. If you only want a different logo, but keep a "powered by" message with the software name, a custom template would be the currently recommended way to go. Since these rarely change, they should not be a hassle for ugrades, if customized. But I'm not opposed to splitting the message at all or allowing configurable custom logos and favicons sets. Since we require the GD library for the user icons in the discussions, we might take a single logo and generate the different favicon flavours, if not present on disk, to make it simpler for the admins. |
+1 : Problem: I have open the same, today : |
Is there any update on this? E.g. using your own favicon and/or logo within your own PrivateBin instance? |
Yes, you can: create a copy of one of the templates and tweak the things you'd like to change, like the logo, favicon, etc. |
Thanks, I have looked into this, but I can only find something about icons (which seems to be about icons of users, not logos). Also, it's not really clear how to configure it, let alone when using it in combination with Docker (Compose). |
You would bind mount both the custom template and config file into the appropriate locations in the image. For example:
This would add your new template file
In your custom template file you could then replace all the img-tags source addresses to point to your own images, etc. Note that our docker image will cache the php code on first use and will need to be restarted when you update the template file, in order to flush the php opcache. |
Wanted to bump this if this can be considered for a future release? Mainly using custom icons, logos and favicons. Currently I copy some icons manually and override the built-in ones. I've also used a custom template over the years but it's very annoying to maintain :/ |
Okay, seems like there is some demand for that. I've created a discussion/poll on https://github.com/orgs/PrivateBin/discussions/1321 where you can vote for if, and if so, what should be customizable. (And yeah, unfortunately AFAIK GitHub does not support multiple answers/multi-choice answers, unfortunately yet.) |
Hi
I have a few small suggestions for improving user customization. One small issue to address, plus a few additional suggestions.
Problem:
If you edit the
name
configuration setting, it changes the software description tooIn my opinion, it should not be modifying the description of the software with a new name unless it's a completely different product/fork.
Solution:
Include a "powered-by" style footer message when a custom
name
is configured.If modified:
If not modified:
Suggestion/wishlist:
New configuration options:
tagline = "because taglines should be editable"
(hide hyphen between tagline and name if empty)customFavicon = true
- reads from /userstyles/favicon/<favicon files>customLogo = mylogo.svg
- reads from /userstyles/mylogo.svgcustomCss = true
- reads from /userstyles/user.css, which could be used to override default CSS classes by simply reading the user.css class lastfooter = false
to disable the footer entirelyMaybe not set up exactly like that, but you get the idea.
Currently, the above changes require modifications to the PHP source, which need to be manually edited again after each software update. Changing via the config file and reading custom files from an optional folder would make software updates easier to manage and allow for greater user customization.
The text was updated successfully, but these errors were encountered: